[Busy] incorrect vote value for users powering down

Project Information

I reported an issue and made a fix and pull request.

Issue: https://github.com/busyorg/busy/issues/2141
PR: https://github.com/busyorg/busy/pull/2143

Expected behavior

The vote value should be shown correctly for users powering down.

Actual behavior

The vote value doesn't take power down into account. Since full power down takes 13 weeks, this may not be that significant in the beginning, but as time goes by, the difference is getting bigger and bigger, as shown in the example below.

I analyzed the code, and this is due to the wrong calculation of the total share for a user powering down. I made a fix and pull request.

How to reproduce

Pick any user powering down and check the vote value. A user who is almost finishing entire power down is easy to check, since the difference can be quite large, as you can see in the Recording Of The Bug section.

For instance, @ned is a good example, who is powering down for 11 weeks already.
@ned

Compare this with @ned

  • Browser/App version: Any
  • Operating system: Any

Recording Of The Bug

Busy doesn't reflect power-down (vote value is almost twice than the true value, next week it'll be more than twice unless this user doesn't stop powering down.)

Steempeak, for instance, shows the correct vote value

Just in case, here is the proof that Busy's vote value is wrong: Ned made an 1% upvote a few hours ago, and it's value is $0.03 (not $0.06~7).

https://steemd.com/steem/@cardboard/re-ned-re-jacekw-re-steemitblog-new-year-new-devportal-updates-20190104t021857649z

GitHub Account

https://github.com/economicstudio

Issue: https://github.com/busyorg/busy/issues/2141
PR: https://github.com/busyorg/busy/pull/2143

H2
H3
H4
Upload from PC
Video gallery
3 columns
2 columns
1 column
9 Comments